chore(docs): update contributing guidelines (charmkeeper)#170
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
erinecon
requested review from
cbartz,
florentianayuwono,
javierdelapuente,
weiiwang01,
yanksyoon and
yhaliaw
as code owners
florentianayuwono
approved these changes
Apr 22, 2026
cbartz
reviewed
Apr 22, 2026
…nto charmkeeper/update-contributing-guidelines
florentianayuwono
pushed a commit
that referenced
this pull request
Apr 22, 2026
* chore(docs): update contributing guidelines (charmkeeper) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(docs): build errors * chore: clarify PR checklist and remove unnecessary item * chore(docs): revert changes in CONTRIBUTING.md * fix(docs): whoops we're ignoring the changelog * fix: update pr checklist to incorporate previous items, remove duplicate items --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
florentianayuwono
added a commit
that referenced
this pull request
Apr 29, 2026
* feat: enable log forwarding through otel collector * chore(deps): update dependency packaging to v26.1 (#180) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency sphinx-ubuntu-images to v0.2.0 (#181) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): replace astral-sh/setup-uv action with astral-sh/setup-uv v8 (#182) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update module github.com/jackc/pgx/v5 to v5.9.2 (#183) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(dashboard): remove dead override hiding job queue time series (#184) * fix(dashboard): remove dead override hiding job queue time series The "Job queue time" panel had a leftover hideSeriesFrom override that excluded every series except one specific named expression. Combined with the panel's current query (which already aggregates with sum by (le)), the override hid all data, leaving an empty chart. The override is obsolete now that the query collapses every label except le into a single combined histogram, so removing it restores visualisation without any other change. * ci: pin astral-sh/setup-uv to v8.1.0 The astral-sh/setup-uv repository does not publish a floating v8 major tag (only v8.0.0 and v8.1.0 specific tags exist), so referencing @v8 fails to resolve and breaks the workflow on every PR. * chore: update Copilot collections to v0.11.0 (#172) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com> * chore(docs): update contributing guidelines (charmkeeper) (#170) * chore(docs): update contributing guidelines (charmkeeper) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(docs): build errors * chore: clarify PR checklist and remove unnecessary item * chore(docs): revert changes in CONTRIBUTING.md * fix(docs): whoops we're ignoring the changelog * fix: update pr checklist to incorporate previous items, remove duplicate items --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: run shell as bash * Update docs/how-to/enable-log-forwarding.md Co-authored-by: Erin Conley <erin.conley@canonical.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erin Conley <erin.conley@canonical.com> * fix docs * add index * Update actions/enable-log-forwarding/enable-log-forwarding.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update actions/enable-log-forwarding/enable-log-forwarding.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * address code reviews Co-authored-by: Copilot <copilot@github.com> * add license Co-authored-by: Copilot <copilot@github.com> * fix docs Co-authored-by: Copilot <copilot@github.com> * refactor code Co-authored-by: Copilot <copilot@github.com> * Apply suggestions from code review Co-authored-by: Erin Conley <erin.conley@canonical.com> * address code reviews Co-authored-by: Copilot <copilot@github.com> * remove pyyaml Co-authored-by: Copilot <copilot@github.com> * parameterized test Co-authored-by: Copilot <copilot@github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Erin Conley <erin.conley@canonical.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
florentianayuwono
added a commit
that referenced
this pull request
Apr 30, 2026
* feat: enable log forwarding through otel collector * chore(deps): update dependency packaging to v26.1 (#180) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency sphinx-ubuntu-images to v0.2.0 (#181) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): replace astral-sh/setup-uv action with astral-sh/setup-uv v8 (#182) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update module github.com/jackc/pgx/v5 to v5.9.2 (#183) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(dashboard): remove dead override hiding job queue time series (#184) * fix(dashboard): remove dead override hiding job queue time series The "Job queue time" panel had a leftover hideSeriesFrom override that excluded every series except one specific named expression. Combined with the panel's current query (which already aggregates with sum by (le)), the override hid all data, leaving an empty chart. The override is obsolete now that the query collapses every label except le into a single combined histogram, so removing it restores visualisation without any other change. * ci: pin astral-sh/setup-uv to v8.1.0 The astral-sh/setup-uv repository does not publish a floating v8 major tag (only v8.0.0 and v8.1.0 specific tags exist), so referencing @v8 fails to resolve and breaks the workflow on every PR. * chore: update Copilot collections to v0.11.0 (#172) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com> * chore(docs): update contributing guidelines (charmkeeper) (#170) * chore(docs): update contributing guidelines (charmkeeper) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(docs): build errors * chore: clarify PR checklist and remove unnecessary item * chore(docs): revert changes in CONTRIBUTING.md * fix(docs): whoops we're ignoring the changelog * fix: update pr checklist to incorporate previous items, remove duplicate items --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: run shell as bash * Update docs/how-to/enable-log-forwarding.md Co-authored-by: Erin Conley <erin.conley@canonical.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erin Conley <erin.conley@canonical.com> * fix docs * add index * Update actions/enable-log-forwarding/enable-log-forwarding.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update actions/enable-log-forwarding/enable-log-forwarding.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * address code reviews Co-authored-by: Copilot <copilot@github.com> * add license Co-authored-by: Copilot <copilot@github.com> * fix docs Co-authored-by: Copilot <copilot@github.com> * refactor code Co-authored-by: Copilot <copilot@github.com> * Apply suggestions from code review Co-authored-by: Erin Conley <erin.conley@canonical.com> * address code reviews Co-authored-by: Copilot <copilot@github.com> * remove pyyaml Co-authored-by: Copilot <copilot@github.com> * parameterized test Co-authored-by: Copilot <copilot@github.com> * fix: use otlp exporter type instead of otlp_grpc The opentelemetry-collector snap does not register an 'otlp_grpc' exporter type. The correct type is 'otlp', which uses gRPC by default. 'otlp_grpc' caused the collector to fail to start after the config fragment was written. Also update the self-hosted smoke test to use the runner-injected OTLP endpoint (removing the hardcoded localhost) and write real log entries after forwarding is configured, so logs reach Loki. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: add tls insecure to generated otlp exporter config The OTLP endpoint otlp.actions.self-hosted-runners.internal:4317 uses a self-signed certificate that does not match its hostname. The existing github.yaml config already sets tls.insecure: true for the same endpoint. Add the same setting to the generated exporter fragment to prevent the TLS handshake failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix logging action * style: fix black formatting and missing final newline Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Erin Conley <erin.conley@canonical.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Weii Wang <weii.wang@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the contributing guidelines for the GitHub runner charm.
Changes
docs/changelog.mdCONTRIBUTING.md.github/pull_request_template.mddocs/how-to/contribute.rstThis PR was automatically created by charmkeeper.