fix: use otlp exporter type instead of otlp_grpc#194
Merged
florentianayuwono merged 31 commits intomainfrom Apr 30, 2026
Merged
fix: use otlp exporter type instead of otlp_grpc#194florentianayuwono merged 31 commits intomainfrom
florentianayuwono merged 31 commits intomainfrom
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…v v8 (#182) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(dashboard): remove dead override hiding job queue time series The "Job queue time" panel had a leftover hideSeriesFrom override that excluded every series except one specific named expression. Combined with the panel's current query (which already aggregates with sum by (le)), the override hid all data, leaving an empty chart. The override is obsolete now that the query collapses every label except le into a single combined histogram, so removing it restores visualisation without any other change. * ci: pin astral-sh/setup-uv to v8.1.0 The astral-sh/setup-uv repository does not publish a floating v8 major tag (only v8.0.0 and v8.1.0 specific tags exist), so referencing @v8 fails to resolve and breaks the workflow on every PR.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
* chore(docs): update contributing guidelines (charmkeeper) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(docs): build errors * chore: clarify PR checklist and remove unnecessary item * chore(docs): revert changes in CONTRIBUTING.md * fix(docs): whoops we're ignoring the changelog * fix: update pr checklist to incorporate previous items, remove duplicate items --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
The opentelemetry-collector snap does not register an 'otlp_grpc' exporter type. The correct type is 'otlp', which uses gRPC by default. 'otlp_grpc' caused the collector to fail to start after the config fragment was written. Also update the self-hosted smoke test to use the runner-injected OTLP endpoint (removing the hardcoded localhost) and write real log entries after forwarding is configured, so logs reach Loki. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
florentianayuwono
requested review from
cbartz,
javierdelapuente and
yhaliaw
as code owners
florentianayuwono
requested review from
weiiwang01 and
yanksyoon
as code owners
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The OTLP endpoint otlp.actions.self-hosted-runners.internal:4317 uses a self-signed certificate that does not match its hostname. The existing github.yaml config already sets tls.insecure: true for the same endpoint. Add the same setting to the generated exporter fragment to prevent the TLS handshake failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
weiiwang01
approved these changes
Apr 30, 2026
Collaborator
Author
|
fix tested to be working here https://github.com/canonical/platform-engineering-testing/pull/39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
enable-log-forwardingaction was generating a collector config fragment usingotlp_grpcas the exporter name/type. Theopentelemetry-collectorsnap does not register a component type namedotlp_grpc, causing the collector to fail to start immediately after the config was written:Fix
Change
EXPORTER_NAMEfrom"otlp_grpc"to"otlp/github_runner_optin". Theotlptype uses gRPC by default — the/github_runner_optinsuffix is just a distinguishing name. This matches the convention already used by the runner-injectedgithub.yamlconfig (otlp/mimir).Smoke test improvements
otlp-endpoint: 127.0.0.1:4317so the smoke test uses the real runner-injected endpoint and logs actually reach Loki