objectdictionary: Use node_id from DCF if not provided #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Any chance to merge this into the official sources or is there something missing? |
acolomb
reviewed
May 2, 2023
Member
acolomb
left a comment
acolomb
left a comment
There was a problem hiding this comment.
The case change here seems to be related to your PR #347, but the discussion there wasn't finished IIRC. If the parser really is case-sensitive, this has the potential to break people's code. So can we implement a backwards-compatible solution? Given that the EDS spec seems to be case-insensitive anyway.
The node ID change seems fine.
Contributor
Author
|
My bad. I only wanted to fix the node_id thing. Must have messed up the commit. I will update it in the coming days. |
Member
|
@thesummer Are you still going to work on this? Seems like a worthwhile improvement, just got hung up on minor details. |
acolomb
changed the title
acolomb
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When creating a RemoteNode from the objectdictionary, like
then the variables relative to the
NODEIDare not resolved properly, because theNonevalue innode_idis not updated beforebuild_variableis called.This should fix that and still keep the user provided node_id, if provided.