-
Notifications
You must be signed in to change notification settings - Fork 217
Add from_od flag to the RemoteNode.load_configuration
#405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The fixed bug relates to the inability to use a custom can.BusABC implementation in the Network connection process due to hard-coded instantiation of the can.Bus object in the `connect` method.
In the library we have some methods to load settings from OD, for example `node.rpdo.read(from_od=True)`, but we can not do this for entire configuration. This PR fixes it.
|
What exactly is the use case for this? How does it make sense to buy in to the vast exchange of SDO downloads, but then saving a couple of SDO uploads for reading back the actually accepted configuration? |
|
Perhaps its better to just call |
The In essence, there is nothing to fix here IMHO, just don't call |
|
The PDO state is independent of the OD state and when the Maybe |
|
André:
It would be nice to add hint about this in the |
First: I think this discussion belongs on the tracker, not on a PR. |
It doesn't do IO unless |
|
One cannot use PDOs without some initialization when a
Since this discussion is bigger and more principal than the PR, perhaps we should move the discussion to an issue? |
|
The discussion here is mainly relevant to the PR, as I think it fixes something which isn't broken and should thus not be merged.
That's a fair point and as things stand, doing the I/O operations during object creation is opt-in. Frankly I didn't even know about that possible argument, and would never use it myself.
That's a good idea. It doesn't cost much to transfer the (offline) OD info to the PDO states, and it saves doing a So back to the actual PR, I see we have consensus that |
|
FTR, I'd like to take a stab at improving the docs; it is a good opportunity for me to get to know the various APIs of this excellent library better. Cookie-licking disclaimer: if I don't post a PR within a day or two, feel free to beat me to it :) |
In the library we have some methods to load settings from OD, for example
node.rpdo.read(from_od=True), but we can not do this for entire configuration.This PR fixes it.