Closed
Conversation
Collaborator
|
nice work! please fix the errors reported by CI. |
Contributor
Author
|
Ok, I believe I've fixed this by not re-generating the ARM inc files. Presumably that update was incomplete. I was not able to build suite/cstest, but Travis can and it appears to have succeeded. |
aquynh
reviewed
Jun 20, 2019
| @@ -4050,18 +4050,18 @@ static const MCInstrDesc PPCInsts[] = { | |||
| { 1, OperandInfo2 }, | |||
| { 0, nullptr }, | |||
| { 0, nullptr }, | |||
| { 1, OperandInfo2 }, | |||
| { 2, OperandInfo249 }, | |||
Collaborator
There was a problem hiding this comment.
why does this PR modify this array?
Collaborator
There was a problem hiding this comment.
i suppose this is because you run the syntool script on PPC td files?
Contributor
Author
There was a problem hiding this comment.
Yes. I was able to use the sync scripts for a few of the backends, but not all.
Collaborator
There was a problem hiding this comment.
can you restore these parts (so this PR just focuses on adding const), so i can merge this first, and then we will come back to that later?
Remove two conditionals separating identical bits of code. Add "const" markup to MCRegisterDesc and MCRegisterClass. Signed-off-by: Richard Henderson <rth@twiddle.net>
In this case, do not actively strip const. Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
The Mips backend has not been regenerated from LLVM recently, and there are more fixups required than I'd like. Just apply the fixes to the tables by hand for now. Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
The mapping of system register to indexes is easy to generate read-only. Since we know the indexes are between 0 and 31, use uint8_t instead of unsigned. Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces the size of .data from 500k to 288 bytes.
Unlike the previous pull vs master, I've made modifications to suite/synctools/ to add (or not remove) the const markup. Where possible I have regenerated the affected files from LLVM 7.0.1. In other cases that produced non-working output, possibly indicating that synctools has not been adjusted to work with that arch, so I made the changes by hand. As far as I can see, none of the by-hand changes are not also reflected in the python scripts, for when those arches do get regenerated.