Fix for x86_op record for ocaml bindings#1539
Merged
aquynh merged 1 commit intocapstone-engine:masterfrom Sep 26, 2019
Merged
Conversation
aquynh
pushed a commit
that referenced
this pull request
Sep 26, 2019
aquynh
pushed a commit
that referenced
this pull request
Sep 26, 2019
Collaborator
|
merged, thanks! i also cherry-picked this for "v4" & "next" branches, please confirm they all work well. do you mind looking at non-x86 arches? i think they need update, too. |
Contributor
Author
Took a look at the non-x86 arches, the code for them looked fine already! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the
x86_oprecord in the ocaml bindings.Before the change fields such as
sizewhere returned with bad values, for example:After the change the fields are correctly returned to ocaml: