Update Python bindings and test them in CI#2086
Closed
peace-maker wants to merge 7 commits intocapstone-engine:nextfrom
Closed
Update Python bindings and test them in CI#2086peace-maker wants to merge 7 commits intocapstone-engine:nextfrom
peace-maker wants to merge 7 commits intocapstone-engine:nextfrom
Conversation
There used to be tests comparing the output of the C test_* programs with the equivalent test in the binding language. Update the tests to match the Python bindings.
Contributor
|
@peace-maker thank you! Despite plans to unify tests, testing bindings separately is also required, so it's not a duplicate work anyway: #2043 |
Contributor
|
I think it would be a perfect fit for the bug fix release if it happens: #2081 |
Contributor
Collaborator
|
looks nice, but do you mind splitting this PR into a few independent PRs, instead of mixing all of them into one? |
This was referenced Jul 19, 2023
Contributor
|
Resulting PRs:
Should be imported also to the |
Contributor
Author
|
I'll wait with the testing part until the other PRs are merged since it depends on them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a test setup for the python bindings in the
bindings/Makefile, which compare the output of the/tests/test_<arch>programs with the equivalentbindings/python/test_<arch>.pyscripts. They weren't run in CI and the tests were heavily out of sync.I've fixed all issues with the Python bindings that popped up while fixing the tests. This resulted in new bindings for the wasm and sh targets. 🎉
I'm aware of the plans to unify the tests using cstest, but figured any tests for the bindings at all are better than nothing in the meantime. The Java bindings are heavily outdated, so I've disabled tests for them until they're taken care of.