Add back support for relocatable packages#2431
Conversation
3794b56 to
de35bb5
Compare
Could you please open a PR with it? |
Rot127
left a comment
There was a problem hiding this comment.
In general looks good to me. Can you tell me how quickly this becomes "tested" via NixOS?
|
@kabeor Why is the CI not running here? |
No idea, I do not use NixOS. They are doing something different that is specifically recommended against by CMake's documentation. This patch goes back to the behavior before #2134, unless those paths are absolute (as will be the case with NixOS). It's silly this workaround is required, but such is life 🤷🏻♂️ |
|
Really wired, may be affected by github downtime? Can we commit something or open a new pr to see if CI come back? |
|
This one also doesn't run CI: #2447 |
|
If CI doesn't run, it might be the sign of some error in the Actions YAML file. Check "Actions" log of the repository. |
de35bb5 to
7f87c20
Compare
|
Done! |
|
For me all of the checks are green now. |
Your checklist for this pull request
Detailed description
The previous PR #2134 not only 'allowed' an absolute
CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR, it also broke support for relocatable packages if the path was not absolute.These changes should also be cherry-picked in
v5.Discussion: NixOS/nixpkgs#144170