Merged
Conversation
2 tasks
Collaborator
|
Let's wait until we merged something into v5 (like #2443), rebase this one and get the CI results again. Just wouldn't want to merge CMake edits without the CI running before. |
mrexodia
force-pushed
the
relocatable-package-v5
branch
from
ae4bf08 to
4c24935
Compare
Contributor
Author
|
I triggered the CI ( |
Rot127
approved these changes
Aug 18, 2024
Collaborator
Rot127
left a comment
Rot127
left a comment
There was a problem hiding this comment.
Ah yes. This is indeed the smart way :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #2431