Skip to content

[v5] Wheel build fixes: manylinux1, trigger upload on release, Linux AArch64#2443

Merged
kabeor merged 4 commits intocapstone-engine:v5from
Rot127:uni-wheel
Aug 19, 2024
Merged

[v5] Wheel build fixes: manylinux1, trigger upload on release, Linux AArch64#2443
kabeor merged 4 commits intocapstone-engine:v5from
Rot127:uni-wheel

Conversation

@Rot127
Copy link
Copy Markdown
Collaborator

@Rot127 Rot127 commented Aug 16, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes several issues:

  • Remove hard-coded wheel package name manipulation which adds manylinux1
  • Enable AArch64 binaries for Linux again, because the wheel has no longer the undefined name manylinux1_aarch64.
  • Add musllinux package to test script.
  • Trigger upload only on full releases.

Test plan

Only one attempted upload (failing job published):
https://github.com/Rot127/capstone/actions

Lists correct wheels in: https://github.com/Rot127/capstone/actions/runs/10448403223

Closing issues

...

@Rot127 Rot127 marked this pull request as draft August 16, 2024 05:13
@Rot127 Rot127 force-pushed the uni-wheel branch 3 times, most recently from 22026dd to a56a786 Compare August 16, 2024 06:40
@Rot127 Rot127 changed the title Removes the hard coded wheel name manipulation [v5] Wheel build fixes: manylinux1, trigger upload on release, Linux AArch64 Aug 16, 2024
@Rot127 Rot127 marked this pull request as ready for review August 16, 2024 07:08
@Rot127 Rot127 mentioned this pull request Aug 18, 2024
@Rot127 Rot127 added the build & packaging Build system and packaging related label Aug 18, 2024
@kabeor kabeor merged commit 828268c into capstone-engine:v5 Aug 19, 2024
@Rot127 Rot127 added this to the v5.0.3 milestone Aug 19, 2024
@Rot127 Rot127 deleted the uni-wheel branch March 23, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build & packaging Build system and packaging related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants