Skip to content

hotfix: audit save translation#152

Merged
caverav merged 1 commit intodevelopmentfrom
hotfix/audit-save-translation
Oct 16, 2024
Merged

hotfix: audit save translation#152
caverav merged 1 commit intodevelopmentfrom
hotfix/audit-save-translation

Conversation

@caverav
Copy link
Copy Markdown
Owner

@caverav caverav commented Oct 16, 2024

Descripción

Cambia llaves de i18n para guardar audits

Motivación y Contexto

Llaves incorrectas al usar i18n

Tipos de cambios

  • Bugfix (cambio que no interrumpe el funcionamiento y que soluciona un problema)
  • New feature (cambio que no interrumpe el funcionamiento y que añade funcionalidad)
  • Breaking change (corrección o funcionalidad que podría causar que la funcionalidad existente cambie)

Lista de verificación:

  • Mi código sigue el estilo de código de este proyecto.
  • Mi cambio requiere una modificación en la documentación.
  • He actualizado la documentación en consecuencia.
  • Requiere nuevos tests.

Summary by CodeRabbit

  • Nuevas Funciones
    • Actualización de los mensajes de éxito y error en las notificaciones de la función de guardado en el componente de auditoría.
    • Mensajes mejorados para una mejor claridad en el proceso de actualización de auditorías.

@caverav caverav merged commit 8a5c893 into development Oct 16, 2024
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 16, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Los cambios introducidos en este pull request se centran en la función handleSaveButton del componente General en el archivo frontend/src/routes/audits/edit/general/general.tsx. Se han actualizado los mensajes de éxito y error que se muestran a través de las notificaciones toast. El mensaje de éxito se ha modificado de t('auditUpdatedOk') a t('msg.auditUpdatedOk'), y el mensaje de error de t('failedUpdateAudit') a t('err.failedUpdateAudit'). No se han realizado cambios en la lógica o el flujo de control del componente.

Changes

Archivo Resumen de cambios
frontend/src/routes/audits/edit/general/general.tsx Actualización de las claves de traducción para los mensajes de éxito y error en la función handleSaveButton.

Possibly related PRs

  • Hotfix/i18 fixes #103: Los cambios en este PR implican la adición de nuevas claves de traducción para mensajes de error relacionados con la actualización de auditorías, lo que se relaciona directamente con las modificaciones realizadas en el PR principal sobre los mensajes de éxito y error en la función handleSaveButton.

Suggested reviewers

  • Icksir
  • jllanosg
  • Sealra

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant