Skip to content

fix: added i18n translation#178

Merged
caverav merged 1 commit intodevelopmentfrom
bugfix/i18n-translations
Nov 15, 2024
Merged

fix: added i18n translation#178
caverav merged 1 commit intodevelopmentfrom
bugfix/i18n-translations

Conversation

@sealra
Copy link
Copy Markdown
Collaborator

@sealra sealra commented Nov 15, 2024

Descripción

Agrega i18n translations faltantes

Motivación y Contexto

Mejora UX

¿Cómo ha sido probado?

Capturas de pantalla (si es apropiado):

Tipos de cambios

  • Bugfix (cambio que no interrumpe el funcionamiento y que soluciona un problema)
  • New feature (cambio que no interrumpe el funcionamiento y que añade funcionalidad)
  • Breaking change (corrección o funcionalidad que podría causar que la funcionalidad existente cambie)

Lista de verificación:

  • Mi código sigue el estilo de código de este proyecto.
  • Mi cambio requiere una modificación en la documentación.
  • He actualizado la documentación en consecuencia.
  • Requiere nuevos tests.

Summary by CodeRabbit

  • Nuevas Funciones
    • Se ha añadido una nueva clave de mensaje templateDeletedOk para indicar la eliminación exitosa de una plantilla.
  • Mejoras
    • Se ha actualizado la clave de mensaje auditUpdateOk a auditUpdatedOk para mejorar la claridad y consistencia de las cadenas de localización.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 15, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Se han realizado modificaciones en las cadenas de localización dentro del archivo frontend/src/i18n/en-US/index.ts. Los cambios incluyen el renombramiento de la clave de mensaje auditUpdateOk a auditUpdatedOk para mantener la consistencia en la nomenclatura. Además, se ha añadido una nueva clave de mensaje templateDeletedOk, que indica la eliminación exitosa de una plantilla. La estructura general del objeto de localización se mantiene sin cambios significativos en la jerarquía o en las claves existentes.

Changes

Archivo Resumen de cambios
frontend/src/i18n/en-US/index.ts - Clave de mensaje actualizada: auditUpdateOkauditUpdatedOk
- Clave de mensaje añadida: templateDeletedOk

Possibly related PRs

  • hotfix: audit save translation #152: Este PR modifica las claves de localización relacionadas con las actualizaciones de auditoría, específicamente cambiando t('auditUpdatedOk'), que está directamente relacionado con el cambio de nombre de la clave auditUpdateOk a auditUpdatedOk.
  • Missing success toast on audit encryption #171: Este PR añade un nuevo mensaje de localización auditEncryptedOk en el mismo archivo frontend/src/i18n/en-US/index.ts, que es relevante ya que implica modificaciones en las cadenas de localización, similar a los cambios en el PR principal.

Suggested labels

bug

Suggested reviewers

  • Icksir
  • caverav
  • jllanosg
  • massi-ponce
  • iTzGooDLife

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

frontend/src/i18n/en-US/index.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".

(The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/frontend".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install @typescript-eslint/eslint-plugin@latest --save-dev

The plugin "@typescript-eslint/eslint-plugin" was referenced from the config file in "frontend/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sealra sealra requested a review from caverav November 15, 2024 03:50
@caverav caverav merged commit fe90fd3 into development Nov 15, 2024
@caverav caverav deleted the bugfix/i18n-translations branch November 15, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants