Travis: Check the dockerfile builds at the very least#74
Merged
Conversation
This was referenced Jul 31, 2019
Closed
Owner
|
ACK 73fb2b6 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very minimal introduction to travis.
It will only check that bujilding the dockerfile works, but that's better than nothing.
Ideally we would want to outsource running all the tests for every pr apart from running them locally, because why not. But travis has a reasonable limitation of 50 min per job.
I will try propose more ugly improvements to this in #66 , but I think this is a good simple start to build and discuss on top of.
I think we all want this to always work and is easy.