Adding PolicySet parsePolicies method#165
Merged
shaobo-he-aws merged 6 commits intocedar-policy:mainfrom Jul 1, 2024
Merged
Conversation
Signed-off-by: Mark Creamer <mjcream@amazon.com>
Signed-off-by: Mark Creamer <mjcream@amazon.com>
khieta
reviewed
Jun 28, 2024
CedarJava/src/main/java/com/cedarpolicy/model/slice/PolicySet.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Creamer <mjcream@amazon.com>
Also modified the FFI code to actually take the policy id from the Rust output instead of using the atomic policy ID counter from the Java Policy object
Signed-off-by: Mark Creamer <mjcream@amazon.com>
Signed-off-by: Mark Creamer <mjcream@amazon.com>
shaobo-he-aws
approved these changes
Jul 1, 2024
2 tasks
shaobo-he-aws
pushed a commit
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Mark Creamer <mjcream@amazon.com> Signed-off-by: Shaobo He <shaobohe@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38
CedarJava
PolicySet parsePolicies(Path filePath)andPolicySet parsePolicies(String policiesString)methods toPolicySet.PolicySetTestsfile that tests the File path and string methods and some exception cases.cedarpolicy files insrc/test/resourcesdirectory to use for testing.CedarJavaFFI
parsePoliciesJnithat takes a Java String for policies and templates, usesPolicySet::from_strto parse the string intopoliciesandtemplatesand then constructs a JavaPolicySetwith those parameters. Template instantiations are omitted.