Backport changes to release/3.3.x#192
Merged
shaobo-he-aws merged 6 commits intorelease/3.3.xfrom Aug 26, 2024
Merged
Conversation
Signed-off-by: Mark Creamer <mjcream@amazon.com> Signed-off-by: Shaobo He <shaobohe@amazon.com>
shaobo-he-aws
requested review from
aaronjeline,
andrewmwells-amazon,
cdisselkoen,
john-h-kastner-aws and
khieta
khieta
changed the title
release/3.3.xrelease/3.3.x
Contributor
|
Pushed an update to fix CI + merged with Realized we should also backport #142, which adds support for the new schema syntax & gets the corpus tests running (currently they're ignored on the 3.x branches). I'll work on that now & update this PR once done. |
Contributor
|
Ok, after playing around with this for a while, I've decided that backporting #142 isn't worth it because it requires substantial work to resolve merge conflicts. Users who want the new Cedar schema syntax will need to wait until the 4.0 release. So: please review the PR in its current state. |
Signed-off-by: Shaobo He <shaobohe@amazon.com>
cdisselkoen
approved these changes
Aug 23, 2024
andrewmwells-amazon
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: