Adding Policy toJson method#172
Merged
mark-creamer-amazon merged 5 commits intocedar-policy:mainfrom Jul 3, 2024
Merged
Conversation
Signed-off-by: Mark Creamer <mjcream@amazon.com>
Signed-off-by: Mark Creamer <mjcream@amazon.com>
khieta
approved these changes
Jul 3, 2024
Contributor
khieta
left a comment
khieta
left a comment
There was a problem hiding this comment.
Looks fine. Approving for now, although I'd like to see the test cases added.
As discussed offline: I think it's fine to merge the current approach, even though we'll (likely) be adding support for this in the Json FFI in the future. Once the FFI is updated, we can file an issue to update this code as well.
Signed-off-by: Mark Creamer <mjcream@amazon.com>
Signed-off-by: Mark Creamer <mjcream@amazon.com>
shaobo-he-aws
approved these changes
Jul 3, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#171
Policy.java
toJsonmethod that calls a new JNI methodtoJsonJnito return the JSON String for the Policy.interface.rs
toJsonJnithat takes policy source, constructs a rust Policy struct and returns the Json representation.