feat: Make methods public to expose data available#69
Merged
grzuy merged 1 commit intocedarcode:masterfrom Oct 2, 2018
Merged
Conversation
Current implementation hides many data available from authenticators behind the private methods. It is useful to expose them to users of this gem, i.e. logging, auditing, and debugging. I believe this gem should provide a low-level API for RP implementations.
Contributor
|
Hi @sorah, Agree that this helps with debugging, logging and extending. Thank your for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for working on WebAuthn RP helper library for Ruby. I'm maintaining https://github.com/sorah/clarion, which was implemented with legacy U2F API (u2f-api.js), and I have just replaced the legacy implementation of my app with this gem!
Current implementation hides many data available from authenticators behind the private methods. It is useful to expose them to users of this gem, i.e. logging, auditing, and debugging.
I believe this gem should provide a low-level API for RP implementations. Current implementation doesn't expose the most data available from authenticator, and have to implement reference at the entry points (
AuthenticatorAttestationResponseandAuthenticatorAssersionResponse.)AFAIK WebAuthn is designed to be extensible, so it's useless to force RP developers to implement vendor or enterprise-specific extension into this gem.
(I'm gonna send more PRs and issues I noticed...)