Parse signCount and expose at AuthenticatorData#sign_count#70
Parse signCount and expose at AuthenticatorData#sign_count#70brauliomartinezlm merged 3 commits intocedarcode:masterfrom
Conversation
To allow RP to check signature count mismatch https://www.w3.org/TR/2018/CR-webauthn-20180807/#sign-counter
|
@sorah Thank you for the PR! We initially didn't add support to it because it got deprioritized at first as it was state in the recommendation that how to react to the detection of a mismatch depended individually on the RP https://www.w3.org/TR/2018/CR-webauthn-20180807/#sign-counter
But I'm 100% all in to add this validation as long as we provide a way for the gem user to fairly decide on how to react to a mismatch in the sign count. Would love to see opinions in such regard given that the Candidate Recommendation leaves the decision open. |
Yes.
Agreed, I don't think we don't need to implement sign counter validation in |
|
WDYT? I understand there's no reason to hide the data since #69 is merged. |
|
Yeah, this is good to go. Sorry for the delay and thank you for doing this PR 👍 |
|
No worries, thank you! 😺 |
This patch allows RP to check signature count mismatch.
https://www.w3.org/TR/2018/CR-webauthn-20180807/#sign-counter
Note: I assume
AuthenticatorDatais exposed to library users in this PR; see #69