chore(ci): add Node 26 to build-lint-test matrix#1737
Conversation
👷 Deploy request for cedarjs pending review.Visit the deploys page to approve it
|
Greptile SummaryThis PR adds Node 26 to the
Confidence Score: 3/5Safe to merge for pure-JS code paths; native-addon packages may silently reuse a wrong-version cache across the two Node variants until the cache key is fixed. The node_modules cache keys in .github/actions/set-up-job/action.yml — both cache-save steps need the Node version added to their keys. Important Files Changed
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 5s | View ↗ |
nx run-many -t build |
✅ Succeeded | 5s | View ↗ |
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
✅ Succeeded | 2s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 7s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-05-10 10:44:09 UTC
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest] | ||
| node-version: [24, 26] |
There was a problem hiding this comment.
Project overview doc lists only Node 24 as runtime version
docs/implementation-docs/2026-03-26-cedarjs-project-overview.md shows Node.js | version: 24 in the RUNTIME table. Now that CI officially tests Node 26 as well, that table entry may become stale and mislead contributors about supported runtime versions. Consider updating it to reflect both 24 and 26 (or whichever versions the project intends to support).
Context Used: Make sure everything in docs/implementation-docs/2... (source)
|
We can't upgrade to Node 26 yet because we use Yargs 17. See yargs/yargs#2509 and yargs/yargs#2514 |

Adds Node 26 to the
build-lint-testCI matrix per @Tobbe's request.Changes
set-up-jobaction — adds anode-versioninput (default:'24') and passes it toactions/setup-nodebuild-lint-testreusable workflow — adds anode-versionworkflow_callinput and forwards it toset-up-jobci.yml— addsnode-version: [24, 26]to the matrix (resolves to the latest patch for each major), updates the job name templateThe change is purely additive — default behaviour for all other jobs is unchanged.