Skip to content

chore(ci): add Node 26 to build-lint-test matrix #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lisa-assistant wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(ci): add Node 26 to build-lint-test matrix #1737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b21c161
chore(ci): add Node 26 to build-lint-test matrix
lisa-assistant May 10, 2026
1e16eb2
chore(ci): add Node 26 to build-lint-test matrix
lisa-assistant May 10, 2026
9e15060
chore(ci): add Node 26 to build-lint-test matrix
lisa-assistant May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/actions/set-up-job/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ description: >
Enable corepack, set up Node.js, yarn install, and build.

inputs:
node-version:
description: >
The version of Node.js to use.
required: false
default: '24'

set-up-yarn-cache:
description: >
For some actions, setting up the yarn cache takes longer than it would to just yarn install.
Expand Down Expand Up @@ -33,7 +39,7 @@ runs:
- name: ⬢ Set up Node.js
uses: actions/setup-node@v6
with:
node-version: 24
node-version: ${{ inputs.node-version }}

# We have to enable Corepack again for Windows. 🤷
# In general, we're waiting on [this issue](https://github.com/actions/setup-node/issues/531)
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/build-lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
os:
required: true
type: string
node-version:
required: false
type: string
default: '24'

jobs:
build-lint-test:
Expand All @@ -19,6 +23,8 @@ jobs:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
- name: Set up job
uses: ./.github/actions/set-up-job
with:
node-version: ${{ inputs.node-version }}

- name: 🔎 Lint
run: yarn lint
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,13 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
node-version: [24, 26]
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Project overview doc lists only Node 24 as runtime version

docs/implementation-docs/2026-03-26-cedarjs-project-overview.md shows Node.js | version: 24 in the RUNTIME table. Now that CI officially tests Node 26 as well, that table entry may become stale and mislead contributors about supported runtime versions. Consider updating it to reflect both 24 and 26 (or whichever versions the project intends to support).

Context Used: Make sure everything in docs/implementation-docs/2... (source)


name: 🏗 Build, lint, test / ${{ matrix.os }} / node 24 latest
name: 🏗 Build, lint, test / ${{ matrix.os }} / node ${{ matrix.node-version }} latest
uses: ./.github/workflows/build-lint-test.yml
with:
os: ${{ matrix.os }}
node-version: ${{ matrix.node-version }}

tutorial-e2e:
needs: check
Expand Down
Loading