feat(esm): Add missing dependency to packages/testing#360
Conversation
✅ Deploy Preview for cedarjs canceled.
|
There was a problem hiding this comment.
Greptile Summary
This PR adds a missing dependency unplugin-auto-import to the packages/testing package. The dependency is required for the vite plugin auto-import functionality that was introduced in PR #355 as part of the ongoing ESM support work. The package was being imported and used in packages/testing/src/web/vitest/vite-plugin-auto-import.js but wasn't declared as a dependency in the package.json, which would cause module resolution errors for consumers of the testing package.
The change adds "unplugin-auto-import": "19.3.0" to the dependencies section of the testing package's package.json. Additionally, a minor fix was made to add a ./ prefix to the tsconfig path in the build script for consistency ("build:types-cjs": "tsc --build --verbose ./tsconfig.cjs.json").
This is a straightforward dependency fix that ensures the testing package can properly resolve all its required modules when consumed by other projects. The dependency needs to be in the regular dependencies section rather than devDependencies because it's used by exported vite plugins that consumers will use.
Confidence score: 5/5
- This PR is extremely safe to merge with no risk of breaking changes
- Score reflects a simple dependency addition that fixes a clear module resolution issue
- No files require special attention as this is a standard package.json dependency update
1 file reviewed, no comments
|
I find it very unlikely that the changes introduced in this PR actually broke web tests on Windows. I'm going to merge this and then continue investigating |
unplugin-auto-importis used in vite plugins that we added in #355PR (7/n) for adding ESM support. See #349 for PR 1/n in the series