Skip to content

feat(esm): Add missing dependency to packages/testing#360

Merged
Tobbe merged 2 commits into
mainfrom
tobbe-testing-missing-dep
Aug 9, 2025
Merged

feat(esm): Add missing dependency to packages/testing#360
Tobbe merged 2 commits into
mainfrom
tobbe-testing-missing-dep

Conversation

@Tobbe
Copy link
Copy Markdown
Member

@Tobbe Tobbe commented Aug 9, 2025

unplugin-auto-import is used in vite plugins that we added in #355

PR (7/n) for adding ESM support. See #349 for PR 1/n in the series

@Tobbe Tobbe added this to the next-release milestone Aug 9, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 9, 2025

Deploy Preview for cedarjs canceled.

Name Link
🔨 Latest commit 6b4a1ae
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/6897bc605fb499000800b2dd

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds a missing dependency unplugin-auto-import to the packages/testing package. The dependency is required for the vite plugin auto-import functionality that was introduced in PR #355 as part of the ongoing ESM support work. The package was being imported and used in packages/testing/src/web/vitest/vite-plugin-auto-import.js but wasn't declared as a dependency in the package.json, which would cause module resolution errors for consumers of the testing package.

The change adds "unplugin-auto-import": "19.3.0" to the dependencies section of the testing package's package.json. Additionally, a minor fix was made to add a ./ prefix to the tsconfig path in the build script for consistency ("build:types-cjs": "tsc --build --verbose ./tsconfig.cjs.json").

This is a straightforward dependency fix that ensures the testing package can properly resolve all its required modules when consumed by other projects. The dependency needs to be in the regular dependencies section rather than devDependencies because it's used by exported vite plugins that consumers will use.

Confidence score: 5/5

  • This PR is extremely safe to merge with no risk of breaking changes
  • Score reflects a simple dependency addition that fixes a clear module resolution issue
  • No files require special attention as this is a standard package.json dependency update

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@Tobbe Tobbe enabled auto-merge (squash) August 9, 2025 21:25
@Tobbe Tobbe disabled auto-merge August 9, 2025 22:03
@Tobbe
Copy link
Copy Markdown
Member Author

Tobbe commented Aug 9, 2025

I find it very unlikely that the changes introduced in this PR actually broke web tests on Windows. I'm going to merge this and then continue investigating

@Tobbe Tobbe merged commit 6a879d3 into main Aug 9, 2025
121 of 124 checks passed
@Tobbe Tobbe deleted the tobbe-testing-missing-dep branch August 9, 2025 22:08
Tobbe added a commit that referenced this pull request Aug 9, 2025
Tobbe added a commit that referenced this pull request Aug 9, 2025
Tobbe added a commit that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant