Skip to content

feat(esm): Add missing dependency to packages/testing (take 2)#364

Merged
Tobbe merged 1 commit into
mainfrom
tobbe-esm-prep-6
Aug 10, 2025
Merged

feat(esm): Add missing dependency to packages/testing (take 2)#364
Tobbe merged 1 commit into
mainfrom
tobbe-esm-prep-6

Conversation

@Tobbe
Copy link
Copy Markdown
Member

@Tobbe Tobbe commented Aug 10, 2025

unplugin-auto-import is used in vite plugins that we added in #355 and then again in #362

This PR is re-applying #360

@Tobbe Tobbe added this to the next-release milestone Aug 10, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 10, 2025

Deploy Preview for cedarjs canceled.

Name Link
🔨 Latest commit 42b6c00
🔍 Latest deploy log https://app.netlify.com/projects/cedarjs/deploys/6897ecf246aa0e000800c874

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds the missing unplugin-auto-import dependency to the @cedarjs/testing package. The dependency is required for the autoImportsPlugin function that was introduced in previous PRs (#355 and #362) which provides automatic imports for testing utilities like mockContext, mockHttpEvent, and mockSignedWebhook from @cedarjs/testing/api, as well as gql from graphql-tag and context from @cedarjs/context.

The change fixes a runtime dependency issue where the testing package's vitest configuration would fail because unplugin-auto-import/vite was being imported but the dependency wasn't declared in package.json. Additionally, the PR includes a minor path correction to the build script by adding a ./ prefix to tsconfig.cjs.json for consistency with other TypeScript config references in the same file.

This change ensures that consumers of the @cedarjs/testing package can successfully use the vitest integration features that were added in the recent ESM preparation work. The dependency is properly versioned at 19.3.0 and fits into the existing testing package architecture within the CedarJS monorepo.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a straightforward dependency fix with clear justification and proper versioning
  • No files require special attention

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@Tobbe Tobbe merged commit f1c144d into main Aug 10, 2025
52 checks passed
@Tobbe Tobbe deleted the tobbe-esm-prep-6 branch August 10, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant