-
Notifications
You must be signed in to change notification settings - Fork 14
Celestia v3.7.4 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: celestia-main
Are you sure you want to change the base?
Celestia v3.7.4 #27
Conversation
Use new golangci-lint fmt and fix solidity formatter
Update actions/setup-node to v4
Try NOT running the nitro CodeQL build in parallel
…tylus-tests Increase EVM Call timeout to avoid flaky CI
…rchived-repo Bring in Missing BoLD PRs
Upgrade the GitHub Actions
fix gas accounting for eth_call
…_calldata Blob prices should not be used if parent chain doesn't return blob price
Update fastcache
…e-a-fatal-error-for
…lstate-not-in-chain-should-be-a-fatal-error-for GlobalState not in chain should be a fatal error when requesting a confirmed assertion
…r-config-validation Basic seq-coordinator config validation
Close part files after the copy is done
…3509) Co-authored-by: Pepper Lebeck-Jobe <pepper@offchainlabs.com>
There was a bug where if a duplicate message was processed at a segment boundary, then it would cause an empty segment to be inserted, which broke the invariants of the backlog data structure. The invariants being violated wer: 1. Monotonic sequence number order 2. Segment Continuity: segment[n].End() + 1 == segment[n+1].Start() 3. Non-empty Segments: All segments should contain messages 4. Lookup Uniqueness: Each sequence number maps to exactly one segment 5. Cumulative Size Ordering: Later messages have higher cumulative sizes This bug would break most operations on the backlog (eg Get() which uses a binary search) and cause them to have unpredictable behavior.
…rGlobalStateNotInChain
…rGlobalStateNotInChain
…lstate-not-in-chain-should-be-a-fatal-error-for Return a fatal error instead of stopping the StopWaiter in case of Er…
Pull the changes from OffchainLabs/go-ethereum#519 Close NIT-3769
…ize-multigas-3.7.0-backport Improve CPU performance when processing blocks
Also removed deprecated v42-rc.1 since no one should ever use it
…ckport backport adding consensus v41 to Dockerfile
…3596) * Test Genesis assertion on nitro init * revert go.mod changes
(cherry picked from commit 6f3d900)
…firm_backport Make sure to retry fast confirmation on failure
…port stylus target: infer support of previous sse versions from more advanced ones
The tests which use the releases package were failing because we have had more than 50 non-prerelease releases since the last consensus release, and it was only fetching the first 50 pages from the GitHub API.
| name: Build and Test Bold | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out code into the Go module directory | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| submodules: true | ||
|
|
||
| - name: Setup node/yarn | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '24' | ||
| cache: 'yarn' | ||
| cache-dependency-path: "**/yarn.lock" | ||
|
|
||
| - name: Install go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.24.x | ||
|
|
||
| - name: Install Foundry | ||
| uses: foundry-rs/foundry-toolchain@v1 | ||
| with: | ||
| cache: false | ||
| version: v1.0.0 | ||
|
|
||
| - name: AbiGen (nitro) | ||
| run: make contracts | ||
|
|
||
| - name: Get dependencies | ||
| working-directory: ./bold | ||
| run: | | ||
| go get -v -t -d ./... | ||
| - name: Build | ||
| working-directory: ./bold | ||
| run: go build -v ./... | ||
|
|
||
| - name: Test | ||
| working-directory: ./bold | ||
| run: ANVIL=$(which anvil) go test -v -covermode=atomic -coverprofile=coverage.out -timeout=20m ./... | ||
|
|
||
| - name: Upload coverage reports to Codecov | ||
| uses: codecov/codecov-action@v5 | ||
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
To resolve the issue, you need to add a permissions: block specifying the minimal required permissions for this workflow. The permissions block can be added at the root level (just after name: and before on:) to apply to all jobs, or at the job level if specific jobs need different permissions. Based on the provided workflow, most steps only need read access to contents, while the step uploading coverage with codecov/codecov-action sometimes requires only contents: read, but you can check the documentation to confirm if it needs additional permissions (it rarely does). The best fix here is to set permissions: contents: read at the root of the workflow so it's inherited by all jobs. Place the block after name: Go.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Go | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| workflow_dispatch: |
| go-version: 1.24.x | ||
|
|
||
| - name: Install Foundry | ||
| uses: foundry-rs/foundry-toolchain@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step
| run: ANVIL=$(which anvil) go test -v -covermode=atomic -coverprofile=coverage.out -timeout=20m ./... | ||
|
|
||
| - name: Upload coverage reports to Codecov | ||
| uses: codecov/codecov-action@v5 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step
|
|
||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v2 | ||
| uses: codecov/codecov-action@v5 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step
| restore-keys: ${{ runner.os }}-buildx- | ||
| - name: Build nitro-node docker | ||
| uses: docker/build-push-action@v5 | ||
| uses: docker/build-push-action@v6 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step
| cache-to: type=local,dest=/tmp/.buildx-cache-new,mode=max | ||
| - name: Build nitro-node-dev docker | ||
| uses: docker/build-push-action@v5 | ||
| uses: docker/build-push-action@v6 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step
| with: | ||
| go-version: "stable" | ||
| - id: list | ||
| uses: shogo82148/actions-go-fuzz/list@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step: list
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: "stable" | ||
| - uses: shogo82148/actions-go-fuzz/run@v1 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step
|
|
||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v2 | ||
| uses: codecov/codecov-action@v5 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step
| - name: Upload coverage to Codecov | ||
| if: steps.changed-files.outputs.any_changed == 'true' | ||
| uses: codecov/codecov-action@v2 | ||
| uses: codecov/codecov-action@v5 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Overview
updates the main branch to a v3.7.4 compatible release.
NOTE: v3.7.3 is skipped as it was not a required upgrade