-
Notifications
You must be signed in to change notification settings - Fork 2
feat: INFRA-6021 Cronos Mainnet image bump up to v1.5.1 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Dockerfile's Cronos binary download configuration was updated to switch from the testnet release (v1.5.1-testnet) to the mainnet release (v1.5.1). The tarball URL and all extraction/cleanup commands referencing the filename were correspondingly modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
Dockerfile
[high] 11-12: Ensure that certificate validation isn't disabled with wget
(CKV2_DOCKER_3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: guardrails/scan
🔇 Additional comments (1)
Dockerfile (1)
11-12: No changes needed—tarball structure is correct for the existing move command.The mainnet release URL is accessible and the tarball extracts directly to a
bin/directory withcronosdexecutable. Themv ./*command will correctly movebin/from/tmpto/home/cronos/, resulting in/home/cronos/bin/cronosd. The Dockerfile as written is correct.
| RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \ | ||
| && rm cronos_1.5.1_Linux_x86_64.tar.gz && mv ./* /home/cronos/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove --no-check-certificate flag to enforce SSL/TLS validation.
The --no-check-certificate flag disables certificate validation, creating a potential man-in-the-middle attack vector. This is a security risk and should be removed unless there is a documented reason to trust the source without verification.
Apply this diff to remove the flag:
-RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \
+RUN cd /tmp && wget https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \
&& rm cronos_1.5.1_Linux_x86_64.tar.gz && mv ./* /home/cronos/📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \ | |
| && rm cronos_1.5.1_Linux_x86_64.tar.gz && mv ./* /home/cronos/ | |
| RUN cd /tmp && wget https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \ | |
| && rm cronos_1.5.1_Linux_x86_64.tar.gz && mv ./* /home/cronos/ |
🧰 Tools
🪛 Checkov (3.2.334)
[high] 11-12: Ensure that certificate validation isn't disabled with wget
(CKV2_DOCKER_3)
🤖 Prompt for AI Agents
In Dockerfile around lines 11 to 12, the wget invocation uses the
--no-check-certificate flag which disables TLS certificate validation; remove
the --no-check-certificate flag from the wget command so certificate validation
is enforced (ensure the command still succeeds against the upstream URL and
adjust to use an alternative secure fetch method or add CA certs to the image if
needed).
https://github.com/crypto-org-chain/cronos/releases/tag/v1.5.1
https://chainstack.myjetbrains.com/youtrack/issue/INFRA-6021/Cronos-v1.5.1-Upgrades-across-clusters
Summary by CodeRabbit