Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ RUN mkdir -p /home/cronos/data && mkdir -p /home/cronos/config
RUN apt-get update -y && apt-get install wget curl procps net-tools jq lz4 -y

# Download and verify tarball
RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1-testnet_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1-testnet_Linux_x86_64.tar.gz \
&& rm cronos_1.5.1-testnet_Linux_x86_64.tar.gz && mv ./* /home/cronos/
RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \
&& rm cronos_1.5.1_Linux_x86_64.tar.gz && mv ./* /home/cronos/
Comment on lines +11 to +12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Remove --no-check-certificate flag to enforce SSL/TLS validation.

The --no-check-certificate flag disables certificate validation, creating a potential man-in-the-middle attack vector. This is a security risk and should be removed unless there is a documented reason to trust the source without verification.

Apply this diff to remove the flag:

-RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \
+RUN cd /tmp && wget https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \
      && rm cronos_1.5.1_Linux_x86_64.tar.gz && mv ./* /home/cronos/
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
RUN cd /tmp && wget --no-check-certificate https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \
&& rm cronos_1.5.1_Linux_x86_64.tar.gz && mv ./* /home/cronos/
RUN cd /tmp && wget https://github.com/crypto-org-chain/cronos/releases/download/v1.5.1/cronos_1.5.1_Linux_x86_64.tar.gz && tar -xvf cronos_1.5.1_Linux_x86_64.tar.gz \
&& rm cronos_1.5.1_Linux_x86_64.tar.gz && mv ./* /home/cronos/
🧰 Tools
🪛 Checkov (3.2.334)

[high] 11-12: Ensure that certificate validation isn't disabled with wget

(CKV2_DOCKER_3)

🤖 Prompt for AI Agents
In Dockerfile around lines 11 to 12, the wget invocation uses the
--no-check-certificate flag which disables TLS certificate validation; remove
the --no-check-certificate flag from the wget command so certificate validation
is enforced (ensure the command still succeeds against the upstream URL and
adjust to use an alternative secure fetch method or add CA certs to the image if
needed).


# Set permissions
RUN chown -R cronos:cronos /home/cronos && chmod 1777 /tmp
Expand Down