Conversation
etimberg
left a comment
There was a problem hiding this comment.
I didn't see anything majorly wrong with the code. Looks like some tests were affected however, so that needs to be fixed before this can be merged
|
@etimberg it looks like the tests have been fixed for this PR now |
simonbrunel
left a comment
There was a problem hiding this comment.
Thanks @derekellis (would need to resolve conflicts before merge)
|
@derekellis can you rebase this PR so that we can merge it? |
|
@derekellis are you still able to rebase this? |
|
@derekellis it looks like this PR is ready to be merged if you can rebase it |
|
@derekellis thanks for all the effort on this. we'd like to be able to merge, but may end up closing this PR if you aren't able to rebase it |
|
Closing this for now. Please feel free to reopen it once you've rebased it |
|
Since @derekellis has gone dark is this not something that ya'll or someone else could add into the codebase to fix the problem? I'm happy to submit a PR with a rebased version of the code changes above if that would work. |
My proposed fix for issue #4087