Skip to content

Bugfix/4087#4590

Closed
derekellis wants to merge 13 commits intochartjs:masterfrom
derekellis:bugfix/4087
Closed

Bugfix/4087#4590
derekellis wants to merge 13 commits intochartjs:masterfrom
derekellis:bugfix/4087

Conversation

@derekellis
Copy link

My proposed fix for issue #4087

Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see anything majorly wrong with the code. Looks like some tests were affected however, so that needs to be fixed before this can be merged

@benmccann
Copy link
Contributor

@etimberg it looks like the tests have been fixed for this PR now

@etimberg etimberg added this to the Version 2.8 milestone Sep 29, 2017
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @derekellis (would need to resolve conflicts before merge)

@benmccann
Copy link
Contributor

@derekellis can you rebase this PR so that we can merge it?

@etimberg
Copy link
Member

@derekellis are you still able to rebase this?

@benmccann
Copy link
Contributor

@derekellis it looks like this PR is ready to be merged if you can rebase it

@benmccann
Copy link
Contributor

@derekellis thanks for all the effort on this. we'd like to be able to merge, but may end up closing this PR if you aren't able to rebase it

@benmccann
Copy link
Contributor

Closing this for now. Please feel free to reopen it once you've rebased it

@benmccann benmccann closed this Jan 27, 2018
@benmccann benmccann removed this from the Version 2.8 milestone Jan 27, 2018
@CWSites
Copy link
Contributor

CWSites commented May 25, 2018

Since @derekellis has gone dark is this not something that ya'll or someone else could add into the codebase to fix the problem? I'm happy to submit a PR with a rebased version of the code changes above if that would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants