Handle '\n' as newline in tooltips#5521
Merged
simonbrunel merged 2 commits intochartjs:masterfrom Jun 5, 2018
CWSites:master
Merged
Handle '\n' as newline in tooltips#5521simonbrunel merged 2 commits intochartjs:masterfrom CWSites:master
simonbrunel merged 2 commits intochartjs:masterfrom
CWSites:master
Conversation
benmccann
reviewed
May 26, 2018
src/core/core.tooltip.js
Outdated
| } | ||
|
|
||
| /** | ||
| * @Helper to build before and after body lines |
Contributor
There was a problem hiding this comment.
The @ here seems unusual to me
Contributor
Author
|
Hey @benmccann I made your requested changes, any update on getting this fix merged in? |
simonbrunel
approved these changes
May 30, 2018
Contributor
|
@CWSites thanks! I don't have merge access, so you'll need @etimberg or @simonbrunel to merge it. Usually they merge it after both of them have signed off on it. I see @simonbrunel has already approved, so you'll probably just need @etimberg to review now |
Contributor
Author
|
Awesome thank you! |
Contributor
Author
|
bump @etimberg, would really like to get this fix merged in. |
Member
Contributor
Author
|
Thanks @simonbrunel, how will I know what version this is included in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for #4087 based on #4590 using latest code. If there is anything else I can do to help please let me know.
Fixes #4087