Better handling of mixed line / scatter charts#5151
Closed
benmccann wants to merge 1 commit intochartjs:masterfrom
Closed
Better handling of mixed line / scatter charts#5151benmccann wants to merge 1 commit intochartjs:masterfrom
benmccann wants to merge 1 commit intochartjs:masterfrom
Conversation
Closed
Contributor
Author
|
@etimberg @simonbrunel what do you think about this as an approach to what @loicbourgois was fixing in #5134? |
benmccann
force-pushed
the
scatter
branch
2 times, most recently
from
6cdadb6 to
0200511
Compare
This was referenced Jan 19, 2019
simonbrunel
added
type: bug
type: enhancement
and removed
status: awaiting review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to have mixed line and scatter charts
Changes
showLinesfrom global default to chart-type default. Right now if you have a line chart it turns lines on globally including for scatter charts. Scatter charts by definition don't have lines, so this ends up being confusing. This still allows users to override the defaults while stopping line defaults from being applied to scatter charts and vice versa