Implement per-dataset type (default and per-chart) options#5999
Implement per-dataset type (default and per-chart) options#5999simonbrunel merged 11 commits intochartjs:masterfrom
Conversation
kurkle
left a comment
There was a problem hiding this comment.
After the discussion in Slack, this seems like a good start!
15dd6bf to
0b86cf9
Compare
simonbrunel
left a comment
There was a problem hiding this comment.
A minor update in _defaults.
We also need unit tests per controller (line + scatter) to make sure that dataset defaults are correctly handled for every options. And I guess we also need to update the docs about configuring dataset defaults.
0e541e2 to
8c89c7a
Compare
The line chart
We don't allow users to configure default options. |
3c0bad6 to
1be7103
Compare
kurkle
left a comment
There was a problem hiding this comment.
One line to remove and a question to consider.
|
|
Ok, I went ahead and added documentation. I had already added unit tests |
b0bd6f4 to
5c3f88f
Compare
|
I want to combined the candlestick chart with a line chart. Is that possible, and if so, how? |
This fixes mixed line and scatter charts. Issue described in #4587
Closes #5997 & #5151