#5329 Animation duration is not consistent across browsers#5331
Merged
simonbrunel merged 4 commits intochartjs:masterfrom Jan 2, 2019
Merged
#5329 Animation duration is not consistent across browsers#5331simonbrunel merged 4 commits intochartjs:masterfrom
simonbrunel merged 4 commits intochartjs:masterfrom
Conversation
…mation-timing # Conflicts: # src/core/core.animation.js # src/core/core.controller.js
Contributor
Author
|
Chart.js/src/core/core.controller.js Line 525 in 7c3e934 I think it should be enough just to check for "falsy" values here: So code climate won't complain about complexity, am I missing something? |
Member
|
This looks good. |
kurkle
approved these changes
Jan 1, 2019
simonbrunel
approved these changes
Jan 2, 2019
Member
|
Thanks @serhii-yakymuk |
simonbrunel
pushed a commit
that referenced
this pull request
Mar 4, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible solution for #5329