Skip to content

Fix animation regression from 5331#6108

Merged
simonbrunel merged 2 commits intochartjs:masterfrom
kurkle:jerky-animations
Mar 4, 2019
Merged

Fix animation regression from 5331#6108
simonbrunel merged 2 commits intochartjs:masterfrom
kurkle:jerky-animations

Conversation

@kurkle
Copy link
Member

@kurkle kurkle commented Mar 2, 2019

Fixes: #6104

Pen showing 6104 fixed
No regression in timing

Its fixed by making sure we are advancing whether the start time was reset or not.

@benmccann
Copy link
Contributor

Thanks for the quick fix @kurkle! I don't know the animation code well enough to review, so will let the others review this one

etimberg
etimberg previously approved these changes Mar 2, 2019
@simonbrunel simonbrunel added this to the Version 2.8 milestone Mar 3, 2019
@simonbrunel
Copy link
Member

Its fixed by making sure we are advancing whether the start time was reset or not.

I though an animation could only be cancelled, where do we reset the start time for an existing animation?

@kurkle kurkle changed the title Fix jerky animations Fix animation regression from 5331 Mar 3, 2019
@kurkle
Copy link
Member Author

kurkle commented Mar 3, 2019

Went through the issue with @simonbrunel and found out its really just because if we start at 0, nothing changes before the next animation starts at 0. When starting from 1, some transition happens every time.

@kurkle kurkle force-pushed the jerky-animations branch from 069cb87 to 1994a97 Compare March 3, 2019 16:43
@simonbrunel simonbrunel merged commit 344628b into chartjs:master Mar 4, 2019
@simonbrunel
Copy link
Member

Thanks @kurkle for this prompt fix

@kurkle kurkle deleted the jerky-animations branch May 5, 2019 06:39
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chart does not properly update with animation in master

5 participants