Add support for floating bar chart ([start, end]) by gwyneblaidd · Pull Request #6056 · chartjs/Chart.js

gwyneblaidd · 2019-02-08T12:03:05Z

Rebased float-bar support

Original PR: #5262

benmccann

It looks like this is very close. There are two failing tests still

src/core/core.scale.js

src/scales/scale.logarithmic.js

src/controllers/controller.bar.js

src/core/core.scale.js

kurkle

Things to consider, I'm not saying they should be done though 😄

src/controllers/controller.bar.js

src/core/core.scale.js

src/scales/scale.logarithmic.js

src/controllers/controller.bar.js

benmccann · 2019-02-25T12:34:29Z

@gwyneblaidd #6077 which implements the option not to skip borders has been merged now, so you shouldn't need any changes to element.rectangle.js anymore. Can you rebase the PR? Hopefully the other reviewers can take a look at this PR and we can merge it after that. It's very close. Thanks for sticking with it

I normally don't recommend squashing commits, but I find that if you have many commits then squashing them first makes rebasing easier, so you may want to consider in this case (git rebase HEAD~16, replace pick with s for all but the first commit, comment out all but the first commit message, git push -f)

src/scales/scale.logarithmic.js

src/scales/scale.linear.js

src/controllers/controller.bar.js

_autoSkipp rolled back minbarlength. float-bar start fix start fix fix fix fixes fix fix fix fixes unittests comment removed reverse of borderSkipped

nagix

Also, shouldn't we add docs in this PR?

test/fixtures/controller.bar/floatBar/float-bar-horizontal.json

xaviRodri · 2019-04-04T09:50:10Z

Good functionality!
Only one question: this [start, end] will only work for the y-axis, or will we be able to do the same in x-axis too?
Something like: {x: [start, end], y: value}
And a result like this:

gwyneblaidd mentioned this pull request Feb 8, 2019

Float-bar support. The logic is to use array values [bottomY, topY] i… #5262

Closed

benmccann suggested changes Feb 8, 2019

View reviewed changes

src/core/core.scale.js Outdated Show resolved Hide resolved

src/scales/scale.logarithmic.js Outdated Show resolved Hide resolved

simonbrunel changed the title ~~Rebased float-bar support. Flhttps://github.com/chartjs/Chart.js/pull/5262~~ Add support for floating bar chart ([start, end]) Feb 9, 2019

benmccann reviewed Feb 11, 2019

View reviewed changes

src/controllers/controller.bar.js Outdated Show resolved Hide resolved

benmccann reviewed Feb 11, 2019

View reviewed changes

src/controllers/controller.bar.js Show resolved Hide resolved

benmccann reviewed Feb 11, 2019

View reviewed changes

src/core/core.scale.js Outdated Show resolved Hide resolved

kurkle reviewed Feb 11, 2019

View reviewed changes

src/controllers/controller.bar.js Outdated Show resolved Hide resolved

src/core/core.scale.js Show resolved Hide resolved

src/scales/scale.logarithmic.js Outdated Show resolved Hide resolved

src/controllers/controller.bar.js Outdated Show resolved Hide resolved

benmccann reviewed Feb 11, 2019

View reviewed changes

src/controllers/controller.bar.js Outdated Show resolved Hide resolved

simonbrunel added the type: enhancement label Feb 13, 2019

benmccann previously approved these changes Feb 18, 2019

View reviewed changes

src/controllers/controller.bar.js Outdated Show resolved Hide resolved

gwyneblaidd dismissed benmccann’s stale review via 36338ee February 18, 2019 08:08

benmccann previously approved these changes Feb 18, 2019

View reviewed changes

benmccann mentioned this pull request Feb 19, 2019

Allow configuration of borderWidth as object #6077

Merged

benmccann mentioned this pull request Mar 2, 2019

Early parse, stack by parsed value instead of index #6106

Closed

gwyneblaidd dismissed benmccann’s stale review via c9f6167 March 3, 2019 16:43

gwyneblaidd force-pushed the feat/float-bar branch from d6758f1 to c9f6167 Compare March 3, 2019 16:43

benmccann previously approved these changes Mar 3, 2019

View reviewed changes

benmccann mentioned this pull request Mar 8, 2019

Bar Chart y1 and y2 #4863

Closed

etimberg requested changes Mar 17, 2019

View reviewed changes

gwyneblaidd dismissed benmccann’s stale review via 9f1079f March 20, 2019 12:00

FLoat-bar support.

762dd88

_autoSkipp rolled back minbarlength. float-bar start fix start fix fix fix fixes fix fix fix fixes unittests comment removed reverse of borderSkipped

gwyneblaidd force-pushed the feat/float-bar branch from 9f1079f to 762dd88 Compare March 20, 2019 12:48

fix

7596f64

benmccann previously approved these changes Mar 30, 2019

View reviewed changes

etimberg previously approved these changes Mar 30, 2019

View reviewed changes

nagix reviewed Mar 31, 2019

View reviewed changes

test/fixtures/controller.bar/floatBar/float-bar-horizontal.json Outdated Show resolved Hide resolved

Docs + tests optimization

c8f8e95

gwyneblaidd dismissed etimberg’s stale review via c8f8e95 April 23, 2019 00:30

snyk-bot mentioned this pull request Apr 15, 2020

[Snyk] Upgrade chart.js from 2.8.0 to 2.9.3 mc-ireiser/coreui-free-vue-admin-template#5

Open

awilson9 mentioned this pull request Apr 27, 2020

@types/chart.js - add number array chart data type DefinitelyTyped/DefinitelyTyped#44275

Merged

8 tasks

rr22x mentioned this pull request May 12, 2020

Support for floating bar chart pepstock-org/Charba#55

Closed

exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021

Add support for floating bar chart ([start, end]) (chartjs#6056)

0470ce1

This was referenced Jul 5, 2021

Update dependency chart.js to v2.9.4 - autoclosed billmcchesney1/jazz#114

Closed

Update dependency chart.js to v2.9.4 jtimberlake/jazz#128

Open

This was referenced Jul 27, 2021

Update dependency Chart.js to v2.9.4 vavsab/telegram-green-house#43

Closed

Update all vavsab/telegram-green-house#47

Merged

Update dependency chart.js to v2.9.4 SilvinPradhan/Quiz-App-MEAN#14

Merged

This was referenced Oct 14, 2021

Update dependency chart.js to v2.9.4 Web-Dev-Collaborative/DS-n-Algos-Mega-Archive#8

Merged

Update dependency chart.js to v3 Web-Dev-Collaborative/DS-n-Algos-Mega-Archive#19

Closed

jw mentioned this pull request Jan 17, 2022

Update dependency Chart.js to v2.9.4 jw/speed-monitor#16

Open

1 task

This was referenced Jan 21, 2022

chore(deps): update dependency chart.js to v2.9.4 freeCodeCamp/demo-projects#110

Merged

Update dependency Chart.js to v2.9.4 - autoclosed w0rng-archive/work-searh-help#5

Closed

This was referenced Feb 4, 2022

Update dependency chart.js to v2.9.4 - autoclosed billmcchesney1/jazz#220

Closed

chore(deps): update dependency chart.js to v2.9.4 - autoclosed webc-zss2/traefik#95

Closed

mend-for-github-com bot mentioned this pull request Aug 13, 2022

Update dependency chart.js to v2.9.4 opentok/insights-dashboard-sample#65

Merged

1 task

This was referenced Nov 29, 2022

Update dependency chart.js to v2.9.4 - autoclosed cleohari/openproject#3

Closed

Update dependency chart.js to v3 - autoclosed cleohari/discourse#10

Closed

mend-for-github-com bot mentioned this pull request Jan 26, 2023

chore(deps): update dependency chart.js to v2.9.4 - autoclosed billmcchesney1/jazz#299

Closed

1 task

Conversation

gwyneblaidd commented Feb 8, 2019 • edited by simonbrunel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benmccann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kurkle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benmccann commented Feb 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nagix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xaviRodri commented Apr 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

gwyneblaidd commented Feb 8, 2019 •

edited by simonbrunel

Loading

xaviRodri commented Apr 4, 2019 •

edited

Loading