Allow configuration of borderWidth as object#6077
Allow configuration of borderWidth as object#6077simonbrunel merged 13 commits intochartjs:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
|
both, me and codeclimate are happy about this now, feel free to review 😄 |
nagix
left a comment
There was a problem hiding this comment.
I played with the pen for a while, and it all look good to me. Reducing the number of lines in element.rectangle.js seems to be a good sign😊
|
After a long chat with @simonbrunel and many tests with jsperf, applied some optiomizations to parsing. Also added a regression test for chart area clipping. Added regression test was inspired by the thought of it not working after this PR. That turns out to be false. MDN gives a misleading description to
|
|
After loads of more talk and testing with @simonbrunel, decided to go with option C A B C |
nagix
left a comment
There was a problem hiding this comment.
Option C looks good. The result is consistent with the arc element with borderAlign: 'inner'.
|
Thanks @kurkle for this great work! |


Alternative to #6047
Pen (ef842ad)
Pen (c5df9c9)
Fixes: #5565
Fixes: #5071
Fixes: #5709
Fixes: #4681
Related: #3293 (fixed in master already)