Add tests and a sample for radar scriptable line options#6263
Merged
etimberg merged 2 commits intochartjs:masterfrom May 21, 2019
Merged
Add tests and a sample for radar scriptable line options#6263etimberg merged 2 commits intochartjs:masterfrom
etimberg merged 2 commits intochartjs:masterfrom
Conversation
kurkle
reviewed
May 11, 2019
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Couldn't find anything wrong, but didn't go through every thing yet.
simonbrunel
reviewed
May 12, 2019
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Thanks @nagix for this update, just a minor comment to make the image diff more robust in some cases.
| fill: false | ||
| }, | ||
| point: { | ||
| borderColor: function(ctx) { |
Member
There was a problem hiding this comment.
I would probably set a higher border width on all these pointBorderColor tests to make sure the image diff will fail in case of a wrong color.
Contributor
Author
|
Updated image tests based on the review comment and #6269. |
kurkle
previously approved these changes
May 20, 2019
Contributor
Author
kurkle
approved these changes
May 21, 2019
simonbrunel
approved these changes
May 21, 2019
benmccann
approved these changes
May 21, 2019
etimberg
approved these changes
May 21, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* Add tests and a sample for radar scriptable line options * Improve image tests
1 task
This was referenced Jun 2, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5621 added support for line scriptable options for the radar chart, but unit tests were missing. This PR adds tests and updates the radar chart sample.