Apply lineJoin style at the first point in radar charts#6269
Apply lineJoin style at the first point in radar charts#6269simonbrunel merged 2 commits intochartjs:masterfrom
Conversation
|
Just a random note: With |
kurkle
left a comment
There was a problem hiding this comment.
IMO that mock canvas test should be removed.
|
@kurkle The radar chart create a gap with |
|
I agree to remove mock tests if we add image tests. |
|
@kurkle I may have misunderstood your comment - I think the cropped line border with On the other hand, |
|
|
|
@nagix not sure why the |
|
Removed loop line mock tests. |
|
#6282 was created to fix the |
lineJoinstyle is not applied to the first point in radar charts. This PR fixes it by addingctx.closePathif the line has a close path. If it is open, it shifts elements in the point array so that the line is correctly joined at the first point.I will add image tests in #6263 if this PR is merged first.
Master: https://jsfiddle.net/nagix/bf2geq3o/

This PR: https://jsfiddle.net/nagix/e36dp7k8/
