Allow pre-parsed data (to scale id's)#6768
Conversation
|
We'll probably want to update the default scale IDs I also wonder if this would allow us to remove |
|
I'd actually remove support for Could also have the |
benmccann
left a comment
There was a problem hiding this comment.
cool! I'm eager to see how this helps the uPlot benchmark :-)
|
Master: (averages around 270ms) master + this (and So the difference is around 30 ms, which is almost 10% now! Edit: |
|
I think float bar probably won't work because the |
If the user provides the |
benmccann
left a comment
There was a problem hiding this comment.
I think we probably need some docs about scale parsing. E.g. the time scale will require the user to pass milliseconds since the epoch if this option is enabled
We can ignore _custom in this PR and address it later. I think making the user specify _custom is a bit of an ugly API and we can probably come up with something nicer from the user perspective
benmccann
left a comment
There was a problem hiding this comment.
just the two minor docs comments, but looks good to me


The
From #6766 (comment)
Could be this simple.
Data needs to be array of
{x-scale-id: value, y-scale-id: value}Todo: