Store parsed data more similarly to provided data#6814
Merged
etimberg merged 2 commits intochartjs:masterfrom Dec 8, 2019
Merged
Store parsed data more similarly to provided data#6814etimberg merged 2 commits intochartjs:masterfrom
etimberg merged 2 commits intochartjs:masterfrom
Conversation
|
hey @benmccann would you mind throwing me a PR into the uPlot repo with the Chart.js updates needed to run the current v3? i'd like to test periodically :) |
Contributor
Author
|
done! see here: leeoniya/uPlot#65 |
This was referenced Dec 7, 2019
Member
|
This is very similar to #6816 in performance: |
etimberg
previously approved these changes
Dec 7, 2019
kurkle
approved these changes
Dec 7, 2019
etimberg
approved these changes
Dec 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #6768 merged and
parsing: false, the uPlot benchmark is still spending about 10% of its time in_parse. This PR brings it down to a trivial amount.I think what is happening in
masteris that by adding a new_parsedattribute to the element that the element can sometimes no longer fit in the memory allocated to it and so new memory must be allocated with the old being garbage collected. By just using thedatadirectly we see a very big speedup