Use data directly when parsing is disabled#6816
Use data directly when parsing is disabled#6816kurkle wants to merge 5 commits intochartjs:masterfrom
Conversation
src/core/core.datasetController.js
Outdated
| } else { | ||
| parsed = me._parsePrimitiveData(meta, data, start, count); | ||
| } | ||
| if (parsing !== false) { |
There was a problem hiding this comment.
it looks like updateStacks might not work in the case that parsing === false
There was a problem hiding this comment.
parsing: false does not affect doughtnut at all (its overwriting the parsing and will probably not have enough data entries to make any difference anyway).
I fixed the optimized (read: not using _getParsed) internal stuff to work.
Also added a test for the data synchronization that I believe #6814 fails in.
|
Fixed the test. @benmccann can you add that to #6814 (and add the array maintenance required to pass it)? |
|
I added the test to #6814. It passes it. There's no additional array maintenance required. It just replaces the entire array with the user-provided array, so we don't have to do work to keep them in sync |
|
I think it's a bit confusing that when parsing's on we retrieve data from a different place than when parsing is off and that #6814 is a bit more consistent in this regard |
|
I kind of agree. #6814 uses a little more memory and is a bit faster on the |
|
Thank you for providing the test! |
|
@benmccann @kurkle between this and #6814 which is preferred? |
3 participants
Alternative to #6814 and #6815
Master:
PR:
