No need to use rollup commonjs plugin #7122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Checked my related WIP, there I moved the commonjs plugin after babel. |
Contributor
Author
|
Why keep it when we don't need it though? It just slows down the build time |
kurkle
previously approved these changes
Feb 19, 2020
etimberg
previously approved these changes
Feb 19, 2020
Member
|
CI is failing |
Contributor
Author
|
The CI is flaky. It's a single unrelated test that failed and both GitHub actions CIs passed |
benmccann
force-pushed
the
rm-commonjs
branch
from
0eca0ea to
f28f28b
Compare
etimberg
approved these changes
Feb 19, 2020
kurkle
approved these changes
Feb 19, 2020
Member
|
Now I'm not sure why github actions is failing, but it seems unrelated to the action change here |
Contributor
Author
|
Yeah, they were passing before. I'm sure it's unrelated though because I didn't change anything except kick off the builds again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin was causing issues since it gets called before babel and didn't understand some new syntax I introduced
Breaking it off of #7121 to try to understand why the tests are failing on that one