Enable Typedoc excludeNotExported#7121
Conversation
|
Sigh... This works locally, so I'm not sure why the tests are failing on the VMs |
|
Probably need the exclude that was removed few days ago |
|
Try if that one helps: #7099 (comment) |
|
Ok, no other ideas to try. |
b7961e5 to
068f151
Compare
|
Oh, I read somewhere that you need to put the export on separate line in some cases (ie, end of file), when exporting a class as default (and using properties) |
|
Well that would defeat the entire purpose of this PR :-p |
|
This isn't worth spending more time on to me. I'd rather just not use |
|
I was supposed to comment here about moving I think I got it working in #7125 (need to extract the chores from that) |
068f151 to
1eea407
Compare
|
That worked! Thank you so much!! |
8570314 to
503d332
Compare
2cfcd62 to
bb76fd9
Compare
etimberg
left a comment
There was a problem hiding this comment.
It is quite particular about those exports :|
|
Yeah, hopefully they fix that bug in Typedoc, but I think it's generally better this way anyway |
kurkle
left a comment
There was a problem hiding this comment.
Not sure about exporting the singleton classes. Maybe we should at least add a comment there that its only exported for typedocs?
|
Ok, I just added some comments, but am just as happy to remove the For the For the |
b299fb0 to
c9ddcab
Compare
This turns on
excludeNotExportedin typedocIt also contains a lot of workarounds for TypeStrong/typedoc#393 to make it work