Move option resolution to helpers.options#7125
Conversation
57f421a to
c28a291
Compare
58be174 to
3fba019
Compare
|
I didn't review super closely yet. I think it'll be a bit easier to take a look after rebase since a lot of the changes are already in |
|
Thanks for taking a look. I'll change this to "ready for review", when all the non related stuff is merged and rebased, so don't waste too much time on it yet :) |
2538d75 to
0df8468
Compare
932d246 to
130946f
Compare
etimberg
left a comment
There was a problem hiding this comment.
Not sure this is the best way to go, but there are some good changes inside of this that I think are worth merging such as moving to static _defaults on the element classes.
b342c24 to
7e8cc92
Compare
|
This is a pretty big one. Perhaps it could be broken into multiple PRs? |
|
#7135 is from this. I'm kind of holding back, because it seems the older ones become stale if there are many PR's. |
|
Rebase this one now that #7135 has been merged? |
|
rebased |
|
Probably not going to get merged, so I'll just close this. |
| const indexable = (key, index) => notIndexable.indexOf(key) !== -1 ? undefined : index; | ||
|
|
||
| /** | ||
| * @param {*} elementType |
There was a problem hiding this comment.
This function is used enough in core code that it could be helpful to add descriptions to these parameters
|
A couple notes of things I noticed:
|
steppedLine=steppedorlineStepped(with type prefix))'hover'prefix inactivemodechart.options(because ofspanGaps)downsides