Alphabetize element default options#7170
Merged
etimberg merged 3 commits intochartjs:masterfrom Mar 1, 2020
Merged
Conversation
etimberg
previously approved these changes
Feb 29, 2020
Member
|
I think the Arc defaults also need to be alphabetized https://github.com/chartjs/Chart.js/blob/master/src/elements/element.arc.js#L11 |
Contributor
Author
|
Done. Good catch! |
etimberg
previously approved these changes
Feb 29, 2020
Member
|
CI is failing due to a missing comma in the line file |
etimberg
approved these changes
Mar 1, 2020
kurkle
approved these changes
Mar 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7125 alphabetized the default options. I'm sending this as a separate PR since it makes it a lot easier to tell what was added to compare the two alphabetized lists