Rename steppedLine to stepped #7127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Feb 19, 2020
Contributor
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
I'm fine with either name. I wonder if this one is worth the migration cost?
etimberg
previously approved these changes
Feb 19, 2020
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Also no real preference on this
Contributor
|
Will we also rename |
Member
Author
|
Yes, I'd go with |
benmccann
approved these changes
Feb 19, 2020
etimberg
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another extract from #7125
Just because
line.steppedLineis kind of redundant.