added Check Imports action #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re and there is a small circular issue
adcreare
requested changes
Nov 29, 2022
Contributor
adcreare
left a comment
adcreare
left a comment
There was a problem hiding this comment.
Looks good - few minor things
package-denier/action.yml
Outdated
| name: Package Denier | ||
| description: Check for banned packages | ||
| runs: | ||
| using: node16 |
Contributor
There was a problem hiding this comment.
Probably best this uses node18 - actually that probably goes for all the actions as they are all using 16 at the moment.
| return key.slice(key.lastIndexOf(prefix) + prefix.length); | ||
| } | ||
|
|
||
| function compareSemverVersions(version1: string, version2: string): number { |
Contributor
There was a problem hiding this comment.
would it make sense to use the npm semver package here? https://github.com/npm/node-semver - as its made by the NPM people its probably going to get updates for any additional operators they add? It includes a comparison operator
src/package-denier/rules.ts
Outdated
| /* | ||
| This is the list of packages that are not allowed to be imported. | ||
| */ | ||
| const rules: Rule[] = [['@aws-sdk/client-*', '>', '3.1.0']]; |
Contributor
There was a problem hiding this comment.
Should be 3.193.0 I believe thats the last version we've had live without issues inside aws-nock.
Also should add:
got > 11.8.5get-port > 5.1.1antlr4 > 4.9.3@aws-sdk/credential-provider-ini > 3.193.0@aws-sdk/credential-provider-node > 3.193.0@aws-sdk/smithy-client > 3.193.0@aws-sdk/types > 3.193.0
|
Coverage after merging add-package-denier-action into main will be
Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21