Skip to content

added Check Imports action #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlansley merged 14 commits into from
Dec 19, 2022
Merged

added Check Imports action #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
37edb00
added package denier action
lukebrdn Nov 28, 2022
0f59a7c
add package denier to action workflow
lukebrdn Nov 28, 2022
d4bd593
moved denier to ci
lukebrdn Nov 28, 2022
dce503a
changed action location temporarily for testing
lukebrdn Nov 28, 2022
bfc018f
tweaked some stuff to see if it is necessary
lukebrdn Nov 28, 2022
fb83d61
refactored to improve naming and enable a more helpful error message
lukebrdn Nov 28, 2022
c79d8c6
put back some yml config because it seems like they were needed
lukebrdn Nov 28, 2022
0a3c6f1
added back error throw that copilot sneakily removed
lukebrdn Nov 28, 2022
243cce3
removed banned package from devDeps
lukebrdn Nov 28, 2022
d5cbbc8
removed branch specific workflow
lukebrdn Nov 28, 2022
5545266
re-added branch specific workflow with plans to update to main once m…
lukebrdn Nov 28, 2022
16388b5
removed package denier from workflow bc it is not clear we want it he…
lukebrdn Nov 28, 2022
d560d23
changed to use node/semver, changed name and naming for clarity
lukebrdn Dec 2, 2022
9cc3ea9
fixed typo in test
lukebrdn Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- name: Install dependencies
- name: Install Dependencies
run: npm ci --ignore-scripts
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- name: Install dependencies
- name: Install Dependencies
run: npm ci --ignore-scripts
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down
6 changes: 6 additions & 0 deletions check-imports/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
name: Check Imports
description: Ensure imported packages are allowed for use.
runs:
using: node18
pre: '../setup.mjs'
main: ../build/check-imports/index.js
2 changes: 1 addition & 1 deletion coverage-reporter/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ inputs:
description: Title to add to the comment
required: false
runs:
using: node16
using: node18
pre: '../setup.mjs'
main: ../build/coverage-reporter/index.js
57 changes: 23 additions & 34 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,16 @@
"@actions/core": "^1.9.1",
"@actions/github": "^5.1.0",
"@octokit/rest": "^19.0.4",
"debug": "^4.3.4"
"debug": "^4.3.4",
"semver": "^7.3.8"
},
"devDependencies": {
"@checkdigit/eslint-config": "^7.2.2",
"@checkdigit/jest-config": "^1.0.1",
"@checkdigit/prettier-config": "^3.0.0",
"@checkdigit/typescript-config": "^3.1.0",
"@types/debug": "^4.1.7",
"@types/semver": "^7.3.13",
"@types/uuid": "^8.3.4",
"nock": "^13.2.9",
"rimraf": "^3.0.2",
Expand Down
2 changes: 1 addition & 1 deletion publish-beta/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ inputs:
description: Publish beta command to run
required: true
runs:
using: node16
using: node18
pre: '../setup.mjs'
main: ../build/publish-beta/index.js
Loading