-
Notifications
You must be signed in to change notification settings - Fork 0
replace hard-coded package json sections with the ones from the target package #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces hard-coded package.json sections with those from the target package to improve flexibility and reduce manual maintenance.
- Introduces optional "engine" and "overrides" properties in the PackageJson interface.
- Replaces injected devDependencies with those directly supplied by the target package.
- Adds a new test case to verify a beta npm package with the latest standards.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/validate-npm-package/validate-npm-package.ts | Updates interface properties and package JSON generation logic. |
| src/validate-npm-package/validate-npm-package.spec.ts | Adds a new test case for verifying the beta npm package. |
| package.json | Updates the version number to reflect package updates. |
Comments suppressed due to low confidence (2)
src/validate-npm-package/validate-npm-package.ts:47
- The property 'engine' is typically named 'engines' in package.json. Consider renaming it unless the deviation is deliberate.
...(packageJson.engine === undefined ? {} : { engine: packageJson.engine }),
src/validate-npm-package/validate-npm-package.ts:52
- Removing the hard-coded dependency '@checkdigit/typescript-config' may lead to missing dependencies if the target package does not include it. Verify that the target package's devDependencies fully cover all required dependencies.
devDependencies: packageJson.devDependencies,
|
Coverage after merging update-validate-npm-package-to-latest-standard into main will be
Coverage Report |
adcreare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
✅ PR review status - All reviews completed and approved! |
Fixes #84