Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN_PUBLISH }}
- name: Post Coverage Report
uses: checkdigit/github-actions/coverage-reporter@coverage-folder-handling-conflict
uses: checkdigit/github-actions/coverage-reporter@main
with:
coverage-results-folder-pr: 'coverage-pr'
coverage-results-folder-base: 'coverage'
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@checkdigit/github-actions",
"version": "2.3.0",
"version": "2.4.0",
"description": " Provides supporting operations for github action builds.",
"author": "Check Digit, LLC",
"license": "MIT",
Expand Down
11 changes: 11 additions & 0 deletions src/validate-npm-package/validate-npm-package.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ describe('validate-npm-package', () => {
await verifyNpmPackage();
}, 300_000);

it('successfully verify good beta npm package with the latest standards', async () => {
actionsCoreSpy.mockImplementationOnce((name) => {
if (name === 'betaPackage') {
return '@checkdigit/test-checkdigit@3.4.1-PR.134-31bc';
}
return '';
});

await verifyNpmPackage();
}, 300_000);

// Test uses a bad version of approval package
// and requires skipLibCheck: false in tsconfig.json
// we set it manually in validate npm package as
Expand Down
13 changes: 5 additions & 8 deletions src/validate-npm-package/validate-npm-package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ import { addNPMRCFile } from '../publish-beta/publish';
interface PackageJson {
name: string;
version: string;
engine?: Record<string, string>;
devDependencies?: Record<string, string>;
overrides?: Record<string, string>;
}

const exec = util.promisify(childProcess.exec);
Expand All @@ -42,18 +44,13 @@ async function generateProject(workFolder: string, packageJson: PackageJson): Pr
name: 'test',
version: '0.0.1',
description: 'test project for validating a target library or service npm package',
engines: {
node: '>=20.11',
},
...(packageJson.engine === undefined ? {} : { engine: packageJson.engine }),
type: 'module',
dependencies: {
[packageJson.name]: packageJson.version,
},
devDependencies: {
// including the devDependencies from the target package is necessary for resolving the typing references including but not limited to the types from its service dependencies
...packageJson.devDependencies,
'@checkdigit/typescript-config': '^7.0.1',
},
devDependencies: packageJson.devDependencies,
...(packageJson.overrides === undefined ? {} : { overrides: packageJson.overrides }),
scripts: {
compile: 'tsc --noEmit',
},
Expand Down