Merged
Conversation
Collaborator
|
@fluktuid thanks for the PR! Love it, looks awesome! Can you try looking at the tests as well, please? Would be good to test this one field. I'll open another PR to fix the vulnerabilities so they you can rebase from main. |
fluktuid
force-pushed
the
fix/60-api-private-location
branch
from
20a784f to
d6618f0
Compare
fluktuid
force-pushed
the
fix/60-api-private-location
branch
from
d6618f0 to
4f9ac01
Compare
akosveres
approved these changes
Jun 4, 2025
Collaborator
akosveres
left a comment
akosveres
left a comment
There was a problem hiding this comment.
LGTM! Let's 🚢 it!
I'll add more documentation when we get to that point.
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add privateLocation field to operator and crd
fixes #60
fixes #43