SSH lockdown option #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Contributor
Author
|
Tbh, I don't feel completely confident in providing an opinion on the options themselves. I'm not intimately familiar with these options, so I don't know what all the implications are. Concerning defaults, I guess it's all about what people are doing with the auth. If the goal of the gem is to just to provide auth via publicly available keys, then it may be a bit presumptuous to limit the functionality of that connection by default. On the other hand, if security isn't provided by default, it probably won't be used. So perhaps the issue is more about user education? I'd love to have other weigh in... |
iamvery
added a commit
to iamvery/dotfiles
that referenced
this pull request
Nov 18, 2013
* This option would disable forwarding for the pair's SSH connection. * See chrishunt/github-auth#25 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey man, I've been reading up on SSH security and considering the implications of allowing remote connections to one's machine. I was pleasantly surprised to find that you've added the
--commandoption to the gem, but I thought it might be nice to take it a little further and allow you to specify further "lockdown" of these connections, limiting things such as port forwarding.I admit knowledge of the subject is limited, but hopefully this can kick off a discussion about making things more secure! 😄