SSH options option (:tongue:) #26
Conversation
lib/github/auth/keys_file.rb
Outdated
There was a problem hiding this comment.
Perhaps these options should be stored in a constant rather than literals here?
|
Lol, travis. I just can't make you happy 😄 |
|
Just noticed the name of this branch is "ssl-options"... yeah, long day |
* This option would disable forwarding for the pair's SSH connection. * See chrishunt/github-auth#26 for more information.
|
@chrishunt these have gotten so stale. Is this something you want to continue to think about, or should I just close them out and forget it? I'm happy to fix up the PRs if you'd like me to |
|
@iamvery Are you OK with closing this out for now? Sorry I dropped the ball on it. I think it will make sense to re-open in the future if enough people show interest. Right now, I'm not sure there is a lot of pressure to get this in. |
|
@chrishunt yeah, no worries from me. This is something that I continue to want, but I understand if the demand isn't there 😸 |
3 participants
Here's an alternate approach to #25 that provides a little more flexibility. Now individual options may be provided with the
--ssh-optionscli option. For convenience, I also added the--no-forwardingoption that adds All The Things.